Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty value lists for ArgBuilder::add_value_list #116

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Handle empty value lists for ArgBuilder::add_value_list #116

merged 1 commit into from
Sep 28, 2024

Conversation

TimJentzsch
Copy link
Collaborator

Closes #115

@TimJentzsch TimJentzsch requested a review from BD103 September 28, 2024 11:43
@TimJentzsch TimJentzsch mentioned this pull request Sep 28, 2024
Merged
BD103
BD103 approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix, and thanks for adding a regression test as well!

@BD103 BD103 added the C-Bug A bug in the program label Sep 28, 2024
@BD103 BD103 merged commit 12afdf9 into main Sep 28, 2024
6 checks passed
@BD103 BD103 deleted the 115-handle-empty-iterator branch September 28, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BD103 BD103 BD103 approved these changes

Assignees
No one assigned
Labels
C-Bug A bug in the program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle empty iterator for ArgBuilder::add_value_list
2 participants
@TimJentzsch @BD103